fjy commented on a change in pull request #8688: Remove commit() method Firehose
URL: https://github.com/apache/incubator-druid/pull/8688#discussion_r338329259
##########
File path:
server/src/main/java/org/apache/druid/segment/realtime/plumber/Committers.java
##########
@@ -40,54 +42,15 @@ public void run()
// Do nothing
}
};
+ private static final Supplier<Committer> NIL_SUPPLIER =
Suppliers.ofInstance(NIL);
Review comment:
Agree that we should remove the nil supplier. A follow up PR is fine as long
as we remember to do it...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
