jihoonson commented on a change in pull request #8564: Fix ambiguity about
IndexerSQLMetadataStorageCoordinator.getUsedSegmentsForInterval() returning
only non-overshadowed or all used segments
URL: https://github.com/apache/incubator-druid/pull/8564#discussion_r340239104
##########
File path:
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java
##########
@@ -186,7 +210,7 @@ public void start()
sb.append("SELECT payload FROM %s WHERE used = true AND dataSource = ? AND
(");
for (int i = 0; i < intervals.size(); i++) {
sb.append(
- StringUtils.format("(start <= ? AND %1$send%1$s >= ?)",
connector.getQuoteString())
+ StringUtils.format("(start < ? AND %1$send%1$s > ?)",
connector.getQuoteString())
Review comment:
Nice catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
