zhenxiao commented on a change in pull request #8809: Prohibit
Futures.addCallback(Future, Callback)
URL: https://github.com/apache/incubator-druid/pull/8809#discussion_r343532701
##########
File path:
server/src/main/java/org/apache/druid/server/http/SegmentListerResource.java
##########
@@ -205,7 +209,8 @@ public void onFailure(Throwable th)
log.debug(ex, "Request timed out or closed already.");
}
}
- }
+ },
Review comment:
extract and refactor TaskManagementResource, SegmentListerResource needs
more work, will file separate PR to do it
in this PR, will add comments to both classes at the same time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
