clintropolis commented on a change in pull request #8834: Fixes, adjustments to numeric null handling and string first/last aggregators. URL: https://github.com/apache/incubator-druid/pull/8834#discussion_r343938716
########## File path: core/src/main/java/org/apache/druid/java/util/common/StringUtils.java ########## @@ -107,6 +110,44 @@ public static String fromUtf8(final ByteBuffer buffer) } } + /** + * Encodes "string" into the buffer "byteBuffer", using no more than the number of bytes remaining in the buffer. + * Will only encode whole characters. The byteBuffer's position and limit be changed during operation, but will Review comment: nit: `... limit can be changed ...` or ` ... may be ...`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org