ccaominh commented on a change in pull request #8823: Add InputSource and
InputFormat interfaces
URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343955244
##########
File path:
indexing-service/src/test/java/org/apache/druid/indexing/common/task/IndexTaskTest.java
##########
@@ -115,47 +118,49 @@
@Rule
public ExpectedException expectedException = ExpectedException.none();
+ private static final TimestampSpec DEFAULT_TIMESTAMP_SPEC = new
TimestampSpec("ts", "auto", null);
+ private static final DimensionsSpec DEFAULT_DIMENSIONS_SPEC = new
DimensionsSpec(
+ DimensionsSpec.getDefaultSchemas(Arrays.asList("ts", "dim"))
+ );
private static final ParseSpec DEFAULT_PARSE_SPEC = new CSVParseSpec(
- new TimestampSpec(
- "ts",
- "auto",
- null
- ),
- new DimensionsSpec(
- DimensionsSpec.getDefaultSchemas(Arrays.asList("ts", "dim")),
- new ArrayList<>(),
- new ArrayList<>()
- ),
+ DEFAULT_TIMESTAMP_SPEC,
+ DEFAULT_DIMENSIONS_SPEC,
null,
Arrays.asList("ts", "dim", "val"),
false,
0
);
+ private static final InputFormat DEFAULT_INPUT_FORMAT =
DEFAULT_PARSE_SPEC.toInputFormat();
- @Parameterized.Parameters(name = "{0}")
+ @Parameterized.Parameters(name = "{0}, useInputFormatApi={1}")
public static Iterable<Object[]> constructorFeeder()
{
return ImmutableList.of(
- new Object[]{LockGranularity.TIME_CHUNK},
- new Object[]{LockGranularity.SEGMENT}
+ new Object[]{LockGranularity.TIME_CHUNK, false},
+ new Object[]{LockGranularity.TIME_CHUNK, true},
+ new Object[]{LockGranularity.SEGMENT, false},
+ new Object[]{LockGranularity.SEGMENT, true}
Review comment:
This is a relatively slow test (~15 seconds per parameterized run), so all
the permutations may be overkill. Perhaps remove (SEGMENT, false), which will
still give coverage of both lock granularities and both with/without the input
format API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
