renevan10 commented on a change in pull request #8859: Web console: Fix missing
include future flag for byPeriod rules
URL: https://github.com/apache/incubator-druid/pull/8859#discussion_r345495745
##########
File path: web-console/src/utils/load-rule.ts
##########
@@ -41,7 +42,13 @@ export class RuleUtil {
return (
rule.type +
(rule.period ? `(${rule.period})` : '') +
- (rule.interval ? `(${rule.interval})` : '')
+ (rule.interval ? `(${rule.interval})` : '') +
+ (rule.includeFuture !== false &&
+ (rule.type === 'loadByPeriod' ||
+ rule.type === 'dropByPeriod' ||
+ rule.type === 'broadcastByPeriod')
Review comment:
I've made the changes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
