ccaominh commented on a change in pull request #8864: add sequenceName and currentCheckPoint for backwards compatibility URL: https://github.com/apache/incubator-druid/pull/8864#discussion_r347054768
########## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/actions/CheckPointDataSourceMetadataAction.java ########## @@ -114,4 +137,29 @@ public String toString() ", checkpointMetadata=" + checkpointMetadata + '}'; } + + @Override + public boolean equals(Object o) Review comment: Since you have an override for `equals`, you'll need to also override `hashCode` FYI, the [SonarLint intellij plugin](https://plugins.jetbrains.com/plugin/7973-sonarlint) will give you a warning if you don't override both. While typing this, I just noticed LGTM flagged the same issue. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org