sekingme opened a new pull request #8983: Enable parameters 'resultAsArray' working in materialized-view-selection with a group by query URL: https://github.com/apache/incubator-druid/pull/8983 Enable parameter '**resultAsArray'** working in materialized-view-selection with a group by query. **Reference to the PR: GroupBy array-based result rows. (#8196)** PR (#8196) realize a new resultRow return in group by query and give a parameter choice for user to back to the old appropriate(array- or map-based rows). However, the parameter is not working in materialized-view-selection when user use query type 'view'. In fact, the PR (#8196) totally ignored the situation of materialized-view. So, fix it. The realization has been tested for 2 weeks in our cluster! <hr> This PR has: - [x] been self-reviewed. - [ ] using the [concurrency checklist](https://github.com/apache/incubator-druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.) - [ ] added documentation for new or modified features or behaviors. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/incubator-druid/blob/master/licenses.yaml) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [x] added unit tests or modified existing tests to cover new code paths. - [x] added integration tests. - [x] been tested in a test Druid cluster. <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist above are strictly necessary, but it would be very helpful if you at least self-review the PR. --> <hr> ##### Key changed/added classes in this PR * `MaterializedViewQueryQueryToolChest` * `MaterializedViewQueryQueryToolChestTest`
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
