gianm commented on issue #9111: Add HashJoinSegment, a virtual segment for joins. URL: https://github.com/apache/druid/pull/9111#issuecomment-569757454 Reviewers: by the way, I've done two things in this patch that were suggested on the dev list and I found to be useful. Please let me know if you agree. 1. The new unit tests in this patch are named in the style of https://lists.apache.org/thread.html/381816301bda945b7bf19c05822d1d910282ceb2a96db86b3bfe72b8%40%3Cdev.druid.apache.org%3E. For example see `HashJoinSegmentStorageAdapterTest`. 2. Used Optional a bit more, as suggested in https://lists.apache.org/thread.html/5bb9c985bf0918dfbd2d247aa960bbaf8982654d95c648dba8ef2d67%40%3Cdev.druid.apache.org%3E. For example see `HashJoinSegmentStorageAdapter#getClauseForColumn` and `Exprs.decomposeEquals`. There are still a lot of `@Nullable` where needed to interact with existing interfaces. I didn't think going on a rampage changing them was a good idea.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
