leventov commented on a change in pull request #7306: Reconcile terminology and
method naming to 'used/unused segments'; Rename MetadataSegmentManager to
MetadataSegments
URL: https://github.com/apache/druid/pull/7306#discussion_r369503675
##########
File path:
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java
##########
@@ -908,7 +1009,7 @@ private boolean segmentExists(final Handle handle, final
DataSegment segment)
* Read dataSource metadata. Returns null if there is no metadata.
*/
@Override
- public DataSourceMetadata getDataSourceMetadata(final String dataSource)
+ public @Nullable DataSourceMetadata retrieveDataSourceMetadata(final String
dataSource)
Review comment:
I prefer putting `@Nullable` before the type because semantically it
characterizes the returned type, not the method (there are also modifiers and
other annotations in between).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
