leventov opened a new issue #9285: Dangling CountDownLatch.await() in tests URL: https://github.com/apache/druid/issues/9285 There are several places in tests where the boolean result of `CountDownLatch.await(timeout)` is not tested. It should properly be wrapped into `assertTrue()` in (almost) all cases. Currently, these tests don't really verify the correctness of the production code. See https://github.com/code-review-checklists/java-concurrency#check-await To systematically eradicate these bugs, either the configuration for "Result of method call is ignored" inspection should be edited and the inspection is enabled on error level (which I think is preferable because we want to strictly check this inspection anyway), or a separate [Structural Search pattern](https://github.com/apache/druid/blob/master/dev/teamcity.md#creating-a-custom-inspection-from-a-structural-search-pattern) could be easily created.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
