jihoonson commented on a change in pull request #9306: implement Azure
InputSource reader and deprecate Azure FireHose
URL: https://github.com/apache/druid/pull/9306#discussion_r377984038
##########
File path:
extensions-contrib/azure-extensions/src/main/java/org/apache/druid/storage/azure/AzureByteSource.java
##########
@@ -46,11 +53,19 @@ public AzureByteSource(
@Override
public InputStream openStream() throws IOException
+ {
+ return openStream(0L);
+ }
+
+ public InputStream openStream(long offset) throws IOException
{
try {
- return azureStorage.getBlobInputStream(containerName, blobPath);
+ return azureStorage.getBlobInputStream(offset, containerName, blobPath);
}
catch (StorageException | URISyntaxException e) {
+ log.warn("Exception when opening stream to azure resource,
containerName: %s, blobPath: %s, Error: %s",
Review comment:
I think this log is duplicate with that in `RetryingInputStream` which calls
this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
