jihoonson commented on a change in pull request #9367: string -> expression -> string -> expression URL: https://github.com/apache/druid/pull/9367#discussion_r382849066
########## File path: core/src/main/java/org/apache/druid/math/expr/ExprListenerImpl.java ########## @@ -188,9 +195,15 @@ public void exitLogicalAndOrExpr(ExprParser.LogicalAndOrExprContext ctx) @Override public void exitLongArray(ExprParser.LongArrayContext ctx) { - Long[] values = new Long[ctx.LONG().size()]; + Long[] values = ctx.longArrayBody() == null + ? new Long[0] + : new Long[ctx.longArrayBody().longElement().size()]; for (int i = 0; i < values.length; i++) { - values[i] = Long.parseLong(ctx.LONG(i).getText()); + if (ctx.longArrayBody().longElement(i).getText().equalsIgnoreCase(Expr.NULL_LITERAL)) { + values[i] = null; + } else { + values[i] = Long.parseLong(ctx.longArrayBody().longElement(i).getText()); Review comment: Thanks, sounds good. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org