suneet-s commented on a change in pull request #9559: error on value counter overflow instead of writing sad segments URL: https://github.com/apache/druid/pull/9559#discussion_r397581834
########## File path: processing/src/main/java/org/apache/druid/segment/data/ColumnCapacityExceededException.java ########## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.segment.data; + +import com.google.common.annotations.VisibleForTesting; +import org.apache.druid.java.util.common.StringUtils; + +public class ColumnCapacityExceededException extends RuntimeException +{ + @VisibleForTesting + public static String formatMessage(String columnName) + { + return StringUtils.format( + "Too many values to store for %s column, try reducing maxRowsPerSegment", Review comment: +1 for this operator friendly error message ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org