suneet-s commented on a change in pull request #9576: Add Integration Test for
functionality of kinesis ingestion
URL: https://github.com/apache/druid/pull/9576#discussion_r401064073
##########
File path: integration-tests/docker/tls/generate-server-certs-and-keystores.sh
##########
@@ -17,6 +17,12 @@
cd /tls
+FILE_CHECK_IF_RAN=/tls/server.key
+if [ -f "$FILE_CHECK_IF_RAN" ]; then
+ echo "Script was ran already. Skip running again."
Review comment:
nit: No need to change if everything else looks good. If I saw the log line
as is, it's a little ambiguous - which script? what's the impact of skipping
running again?
```suggestion
echo "Using existing tls keys since /tls/server.key exists - skipping
generation of all certs. To generate certs, delete this file"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
