vogievetsky commented on a change in pull request #9705: add joins to column
tree menu
URL: https://github.com/apache/druid/pull/9705#discussion_r409259660
##########
File path:
web-console/src/views/query-view/column-tree/column-tree-menu/string-menu-items/string-menu-items.tsx
##########
@@ -163,13 +167,80 @@ export const StringMenuItems = React.memo(function
StringMenuItems(props: String
);
}
+ function renderJoinMenu(): JSX.Element | undefined {
+ const { schema, table, columnName, parsedQuery, onQueryChange } = props;
+ if (schema !== 'lookup' || !parsedQuery) return;
+
+ const { originalTableColumn, lookupColumn } =
getCurrentColumns(parsedQuery, table);
+
+ return (
+ <>
+ <MenuItem
+ icon={IconNames.JOIN_TABLE}
+ text={parsedQuery.joinTable ? `Replace Join` : `Join`}
+ >
+ <MenuItem
+ icon={IconNames.LEFT_JOIN}
+ text={`Left Join`}
+ onClick={() => {
+ onQueryChange(
+ parsedQuery.addJoin(
+ 'LEFT',
+ SqlRef.fromString(table, schema).upgrade(),
+ SqlMulti.sqlMultiFactory('=', [
+ SqlRef.fromString(columnName, table, 'lookup'),
+ SqlRef.fromString(
+ lookupColumn === columnName ? originalTableColumn :
'XXX',
+ parsedQuery.getTableName(),
+ ),
+ ]),
+ ),
+ false,
+ );
+ }}
+ />
+ <MenuItem
+ icon={IconNames.INNER_JOIN}
+ text={`Inner Join`}
+ onClick={() => {
+ onQueryChange(
+ parsedQuery.addJoin(
+ 'INNER',
+ SqlRef.fromString(table, schema).upgrade(),
+ SqlMulti.sqlMultiFactory('=', [
+ SqlRef.fromString(columnName, table, 'lookup'),
+ SqlRef.fromString(
+ lookupColumn === columnName ? originalTableColumn :
'XXX',
+ parsedQuery.getTableName(),
+ ),
+ ]),
+ ),
+ false,
+ );
+ }}
+ />
+ </MenuItem>
+ {parsedQuery.onExpression &&
+ parsedQuery.onExpression instanceof SqlMulti &&
+ parsedQuery.onExpression.containsColumn(columnName) && (
+ <MenuItem
+ icon={IconNames.EXCHANGE}
+ text={`Remove Join`}
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
