frnidito commented on issue #8987:
URL: https://github.com/apache/druid/pull/8987#issuecomment-617605330


   > For the integration test, we do have a group of integration tests that 
require the user to provide their own cloud and thus are not run by CI for this 
repo: 
https://github.com/apache/druid/tree/master/integration-tests#running-a-test-that-uses-cloud
   
   @ccaominh, as far as I understood, but please correct me if I am mistaken, 
these tests use the cloud storage and not the cloud to run the middlemanagers 
or bits and pieces of druid (which is our case here).
   
   Anyway, in the meantime, I had a second thought on the integration tests and 
I suppose that at the moment this is quite a big investment for a module that, 
at least now, has only one user: the company where I work :)  If module will 
get more traction, we will be more than happy to add the tests in order to make 
it promotable from `contrib` to `core` as you stated in one of your previous 
messages:
   
   > Also, what do you think about adding an integration test for the new 
extension? I think having an integration test will help ensure future 
contributions do not break functionality of this extension and will also be 
very helpful if we decide to promote this extension from contrib to core later.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to