clintropolis commented on issue #8987: URL: https://github.com/apache/druid/pull/8987#issuecomment-618111432
> >Also, what do you think about adding an integration test for the new extension? I think having an integration test will help ensure future contributions do not break functionality of this extension and will also be very helpful if we decide to promote this extension from contrib to core later. ... > >For the integration test, we do have a group of integration tests that require the user to provide their own cloud and thus are not run by CI for this repo: https://github.com/apache/druid/tree/master/integration-tests#running-a-test-that-uses-cloud ... >@ccaominh, as far as I understood, but please correct me if I am mistaken, these tests use the cloud storage and not the cloud to run the middlemanagers or bits and pieces of druid (which is our case here). I would agree that this would be incredibly hard with the current integration testing framework; without an external zookeeper that both the integration test docker container druid cluster and the provisioned in cloud autoscaled workers could both talk to and discover each other (or some way to make the docker zookeeper to talk directly to the external provisioned instances), nothing will work. I'm not even sure how we would go about making this happen, but in the future could perhaps become possible as we add alternative discovery mechanisms beyond zookeeper, if any would be suitable for this scenario. As such, I don't think it needs to be a blocker for this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
