jihoonson opened a new pull request #9800:
URL: https://github.com/apache/druid/pull/9800
### Description
The `values` in `InDimFilter` can be sometimes huge especially with query
inlining. In that case, the constructor of `InDimFilter` can take a long time
to build a `TreeSet` for storing filter values. AFAIT, `values` doesn't have to
be a `SortedSet`, but can be a `Set` instead except for cache key. To avoid
sorting in the constructor but generate cache key in a deterministic way,
`getCacheKey()` method needs to sort values for generating cache key. Since
this method can be called often, cache key is now cached in memory once it is
created. Also, instead of storing all values in the cache key, a hash of values
is stored now to avoid generating too long hash key.
<hr>
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [x] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
