suneet-s commented on a change in pull request #9800:
URL: https://github.com/apache/druid/pull/9800#discussion_r421011554
##########
File path:
processing/src/main/java/org/apache/druid/query/filter/NotDimFilter.java
##########
@@ -60,10 +60,17 @@ public DimFilter getField()
return ByteBuffer.allocate(1 +
subKey.length).put(DimFilterUtils.NOT_CACHE_ID).put(subKey).array();
}
+ @SuppressWarnings("ObjectEquality")
Review comment:
This suppression is only correct as long as TrueDimFilter and
FalseDimFilter are singletons. If in the future that assumption changes, this
will break, and nothing will notify us of this incorrect behavior if we don't
catch it in code review. That's usually why I try to limit any suppressions,
because it takes a lot of reasoning power to justify why the suppression was
made.
Anyways, I'm ok with this as currently written.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
