morrifeldman commented on a change in pull request #10046: URL: https://github.com/apache/druid/pull/10046#discussion_r444986289
########## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/PartialDimensionDistributionTask.java ########## @@ -200,6 +202,10 @@ public TaskStatus runTask(TaskToolbox toolbox) throws Exception Preconditions.checkNotNull(partitionDimension, "partitionDimension required in partitionsSpec"); boolean isAssumeGrouped = partitionsSpec.isAssumeGrouped(); + final File tmpDir = toolbox.getIndexingTmpDir(); + // Temporary directory is automatically removed when this IndexTask completes. + FileUtils.forceMkdir(tmpDir); Review comment: Good idea. `forceMkdir` has guards to check if the directory already exists and is actually a directory rather than a file, so I didn't add any extra guards in TaskToolbox. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org