jihoonson commented on pull request #10033:
URL: https://github.com/apache/druid/pull/10033#issuecomment-649222738


   ```
   133 F               default boolean sharePartitionSpace(PartialShardSpec 
partialShardSpec)
   134 F               {
   135 F | L | B(0/2)    return 
!partialShardSpec.useNonRootGenerationPartitionSpace();
   136                 }
   ```
   
   The test coverage still complains about this default method, but I believe 
it's being tested in the new tests I added in 
https://github.com/apache/druid/pull/10033/commits/b423e964d258d2ba2f9760fa3224026157e98d0d.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to