ccaominh commented on a change in pull request #9956:
URL: https://github.com/apache/druid/pull/9956#discussion_r445959200
##########
File path: web-console/src/components/segment-timeline/segment-timeline.tsx
##########
@@ -394,14 +394,16 @@ ORDER BY "start" DESC`;
onTimeSpanChange = (e: any) => {
const dStart = new Date();
const dEnd = new Date();
- dStart.setMonth(dStart.getMonth() - e);
+ const capabilities = this.props.capabilities;
+ const timeSpan = parseInt(e, 10) || 3;
Review comment:
Something like this is what I had in mind:
https://github.com/apache/druid/compare/master...ccaominh:fix-console-segment-timeline-query-timespan.
If your fix is reverted so that `this.dataQueryManager.rerunLastQuery()` is
called instead of `this.dataQueryManager.runQuery()`, then the test that
selects a new period will fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
