surekhasaharan commented on pull request #9717:
URL: https://github.com/apache/druid/pull/9717#issuecomment-652089695
@himanshug While we are improving the usability of code coverage checks, it
seems this PR is still failing with the more lenient checks.
```
Diff coverage statistics:
------------------------------------------------------------------------------
| lines | branches | functions | path
------------------------------------------------------------------------------
| 0% (0/10) | 100% (0/0) | 55% (11/20) |
org/apache/druid/java/util/http/client/response/InputStreamFullResponseHolder.java
| 0% (0/14) | 100% (0/0) | 50% (15/30) |
org/apache/druid/java/util/http/client/response/InputStreamFullResponseHandler.java
| 55% (10/18) | 50% (2/4) | 100% (5/5) |
org/apache/druid/sql/calcite/schema/SystemSchema.java
| 0% (0/8) | 0% (0/2) | 100% (4/4) |
org/apache/druid/sql/calcite/schema/MetadataSegmentView.java
------------------------------------------------------------------------------
Total diff coverage:
- lines: 20% (10/50)
- branches: 33% (2/6)
- functions: 59% (35/59)
ERROR: Insufficient line coverage of 20% (10/50). Required 50%.
ERROR: Insufficient branch coverage of 33% (2/6). Required 50%.
```
Some suggestions to move forward:
For `InputStreamFullResponseHolder` and `InputStreamFullResponseHandler` you
could add coverage suppression like
[here](https://github.com/apache/druid/blob/master/pom.xml#L1259)
For `SystemSchema` and `MetadataSegmentView`, the new code around this
check is not covered in the existing `SystemSchemaTest`
```
if (responseHolder.getStatus().getCode() != HttpServletResponse.SC_OK) {
```
It might be possible to cover this for the branch and line coverage for
above condition.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
