clintropolis commented on a change in pull request #10123:
URL: https://github.com/apache/druid/pull/10123#discussion_r448709942
##########
File path:
processing/src/main/java/org/apache/druid/segment/serde/ComplexColumnPartSerde.java
##########
@@ -33,11 +34,17 @@
@Nullable
private final ComplexMetricSerde serde;
private final Serializer serializer;
+ private static final Logger log = new Logger(ComplexColumnPartSerde.class);
private ComplexColumnPartSerde(String typeName, Serializer serializer)
{
this.typeName = typeName;
this.serde = ComplexMetrics.getSerdeForType(typeName);
+ if (this.serde == null) {
+ // Not chosing to fail here since this gets handled as
Review comment:
nit: chosing -> choosing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
