jihoonson opened a new pull request #10341: URL: https://github.com/apache/druid/pull/10341
Fixes https://github.com/apache/druid/issues/10337. ### Description This PR changes `RetryQueryRunner` to call `SpecificQueryRunnable.run()` in its `run()`, so that the segments to query can be determined early enough for `ResultLevelCachingQueryRunner`. In theory, after this change, there might be a little higher chance to see missing segments in response context, but it should be small enough to ignore because the query execution will be likely started immediately right after query distribution tree is constructed. I believe we need integration tests for this fix, but I'm not sure how to add it without introducing a metricsMonitor for integration tests. Welcome any idea. <hr> This PR has: - [x] been self-reviewed. - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.) - [ ] added documentation for new or modified features or behaviors. - [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
