clintropolis commented on a change in pull request #10499:
URL: https://github.com/apache/druid/pull/10499#discussion_r510585207
##########
File path: core/src/main/java/org/apache/druid/math/expr/ExprTypeConversion.java
##########
@@ -74,6 +93,15 @@ public static ExprType operator(@Nullable ExprType type,
@Nullable ExprType othe
return ExprType.STRING;
}
+ // non-vectorized expressions
+ if (type == ExprType.STRING) {
Review comment:
Oh, this check isn't actually necessary anymore, it was from an
intermediary state this branch was in prior to adding the `autoDetect` function
when I was instead trying to use this in the `eval` of operator expressions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
