jihoonson opened a new pull request #10592:
URL: https://github.com/apache/druid/pull/10592


   ### Description
   
   This PR allows Parallel task to run without explicit intervals in 
granularitySpec. If intervals are missing, the parallel task executes an extra 
step for input sampling which collects the intervals to index.
   
   This PR additionally fixes a bug when `numShards` is missing in hash 
partitioning. When `numShards` is missing, the parallel task computes it by 
scanning the whole input. However, the computed numShards was ignored when it's 
serialized into JSON. To fix it, this PR adds another field 
`intervalToNumShardsOverride` which stores the computed numShards per interval 
so that we can handle data skew well across intervals.
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
      - [ ] using the [concurrency 
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
 (Remove this item if the PR doesn't have any relation to concurrency.)
   - [x] added documentation for new or modified features or behaviors.
   - [x] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to