gianm commented on a change in pull request #10653:
URL: https://github.com/apache/druid/pull/10653#discussion_r545336211
##########
File path:
processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/RowBasedGrouperHelper.java
##########
@@ -712,13 +712,13 @@ public InputRawSupplierColumnSelectorStrategy
makeColumnSelectorStrategy(
return new StringInputRawSupplierColumnSelectorStrategy();
case LONG:
return
(InputRawSupplierColumnSelectorStrategy<BaseLongColumnValueSelector>)
- columnSelector -> columnSelector::getLong;
+ columnSelector -> () -> columnSelector.isNull() ? null :
columnSelector.getLong();
Review comment:
IMO, the selectors themselves should ideally cache this computation,
similar to the changes being made in
https://github.com/apache/druid/pull/10614. Therefore, I think this change is
OK, and if there are any issues it should be fixed at the selector level.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
