abhishekagarwal87 commented on a change in pull request #10761:
URL: https://github.com/apache/druid/pull/10761#discussion_r557231606



##########
File path: 
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java
##########
@@ -578,6 +578,10 @@ public void run()
               log.debug("All partitions have been fully read.");
               publishOnStop.set(true);
               stopRequested.set(true);
+
+              // We let the fireDepartmentMetrics know that all messages have 
been read. This way, some metrics such as
+              // high message gap need not be reported
+              fireDepartmentMetrics.markProcessingDone();

Review comment:
       should this be invoked in some other places as well? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to