gianm commented on pull request #10767: URL: https://github.com/apache/druid/pull/10767#issuecomment-760769950
> By the way, I did a similar thing in #10304 to reduce some boilerplate code but used composition instead of inheritance. Added package-private`*BufferAggregatorHelper` classes which in turn are used by vector and buffer aggregator. The helper classes know how to work with buffers. The logic for getting an object out of selector and vectorization stuff was left out for Buffer and Vector classes. Ah, thanks for pointing that out. I haven't had a chance to look at your patch yet. Do you think I should rework this patch to do the same thing you did? I suppose we don't want to have too many ways of doing the same thing in the codebase. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
