FrankChen021 commented on pull request #10825: URL: https://github.com/apache/druid/pull/10825#issuecomment-771325534
Thanks for the amend in doc. The reason why only integers(more accurately, positive integer) are supported in this format is that its design is inspired by JVM parameters such as '-Xms', '-Xmx', which support integer numbers only. It's acceptable to support DOUBLE because sometime numbers like 1.5GiB are more meaningful and simpler than numbers like 1536MiB. For DOUBLE, there're some edge cases to handle. For example, 1.8KiB is equivalent to 1843.2(1.8 * 1024), which rounding mode should be applied to the result ? But this problem is not hard to solve, what we should do is to take a deep consideration and make a choice. At the point the original PR was implemented, I chose to avoid these cases to make the implementation a little bit easier. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
