jihoonson commented on a change in pull request #10812:
URL: https://github.com/apache/druid/pull/10812#discussion_r569892775
##########
File path:
sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidPlanner.java
##########
@@ -113,18 +114,20 @@ public ResourceResult validateAndCollectResources(final
String sql) throws SqlPa
SqlResourceCollectorShuttle resourceCollectorShuttle =
new SqlResourceCollectorShuttle(validator,
frameworkConfig.getDefaultSchema().getName());
validated.accept(resourceCollectorShuttle);
- return new ResourceResult(resourceCollectorShuttle.getResources());
+ plannerContext.setResources(resourceCollectorShuttle.getResources());
Review comment:
nit: maybe `plannerContext.setValidationResult(validationResult)`?
##########
File path:
sql/src/main/java/org/apache/druid/sql/calcite/planner/ValidationResult.java
##########
@@ -24,11 +24,11 @@
import java.util.Set;
-public class ResourceResult
+public class ValidationResult
Review comment:
Please add some javadoc since now it's not intuitive what `resources` in
`ValidationResult` mean.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
