clintropolis commented on a change in pull request #10823:
URL: https://github.com/apache/druid/pull/10823#discussion_r570554058
##########
File path: website/i18n/en.json
##########
@@ -214,6 +217,9 @@
"title": "Amazon Kinesis ingestion",
"sidebar_label": "Amazon Kinesis"
},
+ "development/extensions-core/druid-kubernetes": {
Review comment:
O strange, I this was apparently auto-generated by running spellcheck
locally, I just confirmed this by running ```npm run lint && npm run
spellcheck``` on master and I get the same diff on this file
##########
File path: website/i18n/en.json
##########
@@ -214,6 +217,9 @@
"title": "Amazon Kinesis ingestion",
"sidebar_label": "Amazon Kinesis"
},
+ "development/extensions-core/druid-kubernetes": {
Review comment:
O strange, this was apparently auto-generated by running spellcheck
locally, I just confirmed this by running ```npm run lint && npm run
spellcheck``` on master and I get the same diff on this file
##########
File path: website/i18n/en.json
##########
@@ -214,6 +217,9 @@
"title": "Amazon Kinesis ingestion",
"sidebar_label": "Amazon Kinesis"
},
+ "development/extensions-core/druid-kubernetes": {
Review comment:
O strange, this was apparently auto-generated by running spellcheck
locally, I just confirmed this by running ```npm run lint && npm run
spellcheck``` on website in master and I get the same diff on this file
##########
File path: website/i18n/en.json
##########
@@ -214,6 +217,9 @@
"title": "Amazon Kinesis ingestion",
"sidebar_label": "Amazon Kinesis"
},
+ "development/extensions-core/druid-kubernetes": {
Review comment:
:+1:, I didn't actually realize it was there until you pointed it out, i
just ran the spell check to make sure i fixed the errors in the docs and staged
and pushed up all changes without really looking at them 😅
Any idea what this file is for? Something with localization i would guess,
but not sure if it is important, like should it be another commit to get pulled
in to 0.21.0? Though I guess its possible that since building the website-src
pulls in druid and does this build, that it might pick up the changes that
happen to this file anyway as a side-effect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
