maytasm opened a new pull request #10900:
URL: https://github.com/apache/druid/pull/10900


   Add query granularity to compaction task
   
   ### Description
   
   Add query granularity to compaction task. Note that query granularity is 
still not supported in auto compaction.
   This PR also creates a new class `CompactionGranularitySpec` to use instead 
of `GranularitySpec` when passing query granularity and segment granularity 
into compaction task. This allows the null value (value not given by the user) 
to represent using the original current query granularity and segment 
granularity (this is the existing behavior for compaction task). Note that the 
Compaction task ultimately still converts `CompactionGranularitySpec` to a 
`UniformGranularitySpec` when creating the index ingestion spec
   
   This PR has:
   - [ ] been self-reviewed.
      - [ ] using the [concurrency 
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
 (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to