suneet-s commented on a change in pull request #10901: URL: https://github.com/apache/druid/pull/10901#discussion_r580701520
########## File path: integration-tests/src/test/java/org/apache/druid/tests/security/ITBasicAuthLdapConfigurationTest.java ########## @@ -0,0 +1,558 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.tests.security; + +import com.fasterxml.jackson.core.type.TypeReference; +import com.fasterxml.jackson.databind.ObjectMapper; +import com.google.common.collect.ImmutableList; +import com.google.common.collect.ImmutableMap; +import com.google.inject.Inject; +import org.apache.druid.guice.annotations.Client; +import org.apache.druid.java.util.common.StringUtils; +import org.apache.druid.java.util.common.logger.Logger; +import org.apache.druid.java.util.http.client.CredentialedHttpClient; +import org.apache.druid.java.util.http.client.HttpClient; +import org.apache.druid.java.util.http.client.auth.BasicCredentials; +import org.apache.druid.java.util.http.client.response.StatusResponseHolder; +import org.apache.druid.security.basic.authorization.entity.BasicAuthorizerGroupMapping; +import org.apache.druid.server.security.Action; +import org.apache.druid.server.security.Resource; +import org.apache.druid.server.security.ResourceAction; +import org.apache.druid.server.security.ResourceType; +import org.apache.druid.sql.avatica.DruidAvaticaHandler; +import org.apache.druid.testing.IntegrationTestingConfig; +import org.apache.druid.testing.clients.CoordinatorResourceTestClient; +import org.apache.druid.testing.guice.DruidTestModuleFactory; +import org.apache.druid.testing.utils.HttpUtil; +import org.apache.druid.testing.utils.ITRetryUtil; +import org.apache.druid.testing.utils.TestQueryHelper; +import org.apache.druid.tests.TestNGGroup; +import org.apache.druid.tests.indexer.AbstractIndexerTest; +import org.jboss.netty.handler.codec.http.HttpMethod; +import org.jboss.netty.handler.codec.http.HttpResponseStatus; +import org.testng.Assert; +import org.testng.annotations.BeforeMethod; +import org.testng.annotations.Guice; +import org.testng.annotations.Test; + +import java.nio.charset.StandardCharsets; +import java.util.Collections; +import java.util.List; +import java.util.Map; +import java.util.stream.Collectors; + +@Test(groups = TestNGGroup.LDAP_SECURITY) +@Guice(moduleFactory = DruidTestModuleFactory.class) +public class ITBasicAuthLdapConfigurationTest extends AbstractAuthConfigurationTest +{ + private static final Logger LOG = new Logger(ITBasicAuthLdapConfigurationTest.class); + + private static final String LDAP_AUTHENTICATOR = "ldap"; + private static final String LDAP_AUTHORIZER = "ldapauth"; + + private static final String EXPECTED_AVATICA_AUTH_ERROR = "Error while executing SQL \"SELECT * FROM INFORMATION_SCHEMA.COLUMNS\": Remote driver error: BasicSecurityAuthenticationException: User LDAP authentication failed."; + + + private static final TypeReference<List<Map<String, Object>>> SYS_SCHEMA_RESULTS_TYPE_REFERENCE = + new TypeReference<List<Map<String, Object>>>() + { + }; + + private static final String SYSTEM_SCHEMA_SEGMENTS_RESULTS_RESOURCE = + "/results/auth_test_sys_schema_segments.json"; + private static final String SYSTEM_SCHEMA_SERVER_SEGMENTS_RESULTS_RESOURCE = + "/results/auth_test_sys_schema_server_segments.json"; + private static final String SYSTEM_SCHEMA_SERVERS_RESULTS_RESOURCE = + "/results/auth_test_sys_schema_servers.json"; + private static final String SYSTEM_SCHEMA_TASKS_RESULTS_RESOURCE = + "/results/auth_test_sys_schema_tasks.json"; + + private static final String SYS_SCHEMA_SEGMENTS_QUERY = + "SELECT * FROM sys.segments WHERE datasource IN ('auth_test')"; + + private static final String SYS_SCHEMA_SERVERS_QUERY = + "SELECT * FROM sys.servers WHERE tier IS NOT NULL"; + + private static final String SYS_SCHEMA_SERVER_SEGMENTS_QUERY = + "SELECT * FROM sys.server_segments WHERE segment_id LIKE 'auth_test%'"; + + private static final String SYS_SCHEMA_TASKS_QUERY = + "SELECT * FROM sys.tasks WHERE datasource IN ('auth_test')"; + + @Inject + IntegrationTestingConfig config; + + @Inject + ObjectMapper jsonMapper; + + @Inject + @Client + HttpClient httpClient; + + @Inject + private CoordinatorResourceTestClient coordinatorClient; + + @BeforeMethod + public void before() + { + // ensure that auth_test segments are loaded completely, we use them for testing system schema tables + ITRetryUtil.retryUntilTrue( + () -> coordinatorClient.areSegmentsLoaded("auth_test"), "auth_test segment load" + ); + } + + @Test + public void testSystemSchemaAccess() throws Exception Review comment: This test seems to be doing many things. Can we break it up into smaller tests? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
