a2l007 commented on a change in pull request #10213:
URL: https://github.com/apache/druid/pull/10213#discussion_r595471162
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/SegmentReplicantLookup.java
##########
@@ -59,7 +59,10 @@ public static SegmentReplicantLookup make(DruidCluster
cluster)
if (numReplicants == null) {
numReplicants = 0;
}
- loadingSegments.put(segment.getId(), server.getTier(), numReplicants
+ 1);
+ // Timed out segments need to be replicated in another server for
faster availability
+ if (!serverHolder.getPeon().getTimedOutSegments().contains(segment))
{
+ loadingSegments.put(segment.getId(), server.getTier(),
numReplicants + 1);
Review comment:
Added a config. I've set `replicateAfterLoadTimeout` to false as the
default I feel it might be better to preserve the existing behaviour and admins
need to be aware of this property's behavior before setting it to true. Let me
know what you think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
