maytasm commented on a change in pull request #11025:
URL: https://github.com/apache/druid/pull/11025#discussion_r605358137
##########
File path: docs/ingestion/native-batch.md
##########
@@ -193,6 +213,7 @@ that range if there's some stray data with unexpected
timestamps.
|type|The task type, this should always be `index_parallel`.|none|yes|
|inputFormat|[`inputFormat`](./data-formats.md#input-format) to specify how to
parse input data.|none|yes|
|appendToExisting|Creates segments as additional shards of the latest version,
effectively appending to the segment set instead of replacing it. This means
that you can append new segments to any datasource regardless of its original
partitioning scheme. You must use the `dynamic` partitioning type for the
appended segments. If you specify a different partitioning type, the task fails
with an error.|false|no|
+|dropExisting|If set to true (and `appendToExisting` is set to false and
`interval` is specified in `granularitySpec`), then the ingestion task would
drop (mark unused) all existing segments that are fully contained by the
`interval` in the `granularitySpec` when the task publishes new segments (no
segments would be dropped (marked unused) if the ingestion fails). Note that if
either `appendToExisting` is `true` or `interval` is not specified in
`granularitySpec` then no segments would be dropped even if `dropExisting` is
set to `true`.|false|no|
Review comment:
LGTM. Done
##########
File path: docs/ingestion/native-batch.md
##########
@@ -719,6 +741,7 @@ that range if there's some stray data with unexpected
timestamps.
|type|The task type, this should always be "index".|none|yes|
|inputFormat|[`inputFormat`](./data-formats.md#input-format) to specify how to
parse input data.|none|yes|
|appendToExisting|Creates segments as additional shards of the latest version,
effectively appending to the segment set instead of replacing it. This means
that you can append new segments to any datasource regardless of its original
partitioning scheme. You must use the `dynamic` partitioning type for the
appended segments. If you specify a different partitioning type, the task fails
with an error.|false|no|
+|dropExisting|If set to true (and `appendToExisting` is set to false and
`interval` is specified in `granularitySpec`), then the ingestion task would
drop (mark unused) all existing segments that are fully contained by the
`interval` in the `granularitySpec` when the task publishes new segments (no
segments would be dropped (marked unused) if the ingestion fails). Note that if
either `appendToExisting` is `true` or `interval` is not specified in
`granularitySpec` then no segments would be dropped even if `dropExisting` is
set to `true`.|false|no|
Review comment:
LGTM. Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
