suneet-s commented on pull request #10949: URL: https://github.com/apache/druid/pull/10949#issuecomment-817379603
> > @FrankChen021 To help with reviewing this PR, could you update the PR description to include some notes how you chose to implement the solution for this. For example, it looks like the `AbstractSerializablePairSerde` was based off the `SerializablePairLongStringSerde`. > > Also, it would help if you included a description of the different scenarios you tested, and known unsupported conditions - like your comment about first last aggregators not working in SQL queries. > > Description of this PR has been updated. Let me know if there's anything left. Thanks @FrankChen021 I will take a look again this week! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
