clintropolis commented on a change in pull request #11402:
URL: https://github.com/apache/druid/pull/11402#discussion_r664918151
##########
File path: core/src/main/java/org/apache/druid/utils/ConnectionUriUtils.java
##########
@@ -57,6 +67,194 @@ public static void throwIfPropertiesAreNotAllowed(
}
}
+ public static Set<String> tryParseJdbcUriParameters(String connectionUri,
boolean allowUnknown)
+ {
+ if (connectionUri.startsWith(MYSQL_PREFIX)) {
+ try {
+ return tryParseMySqlConnectionUri(connectionUri);
+ }
+ catch (ClassNotFoundException notFoundMysql) {
Review comment:
I found `Mockito.mockStatic` which lets me model these branches a bit by
just letting me mock the `tryParse{x]ConnectionUri` methods, so the coverage is
a bit better now i think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
