jihoonson opened a new pull request #11419:
URL: https://github.com/apache/druid/pull/11419
### Description
Ingestion tasks can fail in the overlord for various reasons. Currently,
these tasks are marked as failed but their taskStatus doesn't report the error
message properly in most cases. These can be categorized into 3 cases as below.
- Canceled by users. This case is not really task failures, but those tasks
are marked as failed.
- Internal errors. Any sort of internal errors such as unknown tasks or task
assignment timeout are included in this case.
- Sanity checks. This case is similar to internal errors, but the difference
is that the cases tested by these sanity checks should never happen in any case.
Because these tasks fail in the overlord, neither the task logs nor task
reports are available, and thus it's quite hard for users to debug when this
happens unless you have knowledge of the ingestion system internals. This PR
addresses this concern by adding user-friendly error messages in taskStatus.
Since the error message field is truncated, it should contain a simple message
that leads users to reading logs for further investigation. The 3 cases above
should change as below after this PR.
- Canceled tasks should report in taskStatus that they are canceled.
- Internal errors should report a simple user-friendly error message in
taskStatus.
- Sanity checks should also report a simple user-friendly error message in
taskStatus.
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not
all of these items apply to every PR. Remove the items which are not done or
not relevant to the PR. None of the items from the checklist below are strictly
necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [z] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [z] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
