juhoautio-rovio commented on pull request #10920: URL: https://github.com/apache/druid/pull/10920#issuecomment-876330460
@JulianJaffePinterest thanks. > I'd love any suggestions you might have on improving the documentation I would expect to see the most common implicit partitioner method used in the sample code for Writer https://github.com/JulianJaffePinterest/druid/blob/spark_druid_connector/docs/development/extensions-core/spark.md#writer I suppose that would simply mean including the sample from your comment https://github.com/apache/druid/pull/10920#issuecomment-849417236 above: the one about `Using the new partitioners and the ergonomic approach to passing the a partition map to the writer`. I would also expect a table that lists the provided partitioners + the corresponding implicit methods for using them conveniently. ---- > They are actually mentioned in the extension docs Do you mean the doc section [Partitioning & PartitionMaps](https://github.com/JulianJaffePinterest/druid/blob/spark_druid_connector/docs/development/extensions-core/spark.md#partitioning--partitionmaps)? One partitioner class name is mentioned in this section: `HashedNumberedSegmentPartitioner` – what about others? It also has this remark: > see the provided partitioners for examples Is it just my mistake to not find where those are listed? If I should be looking at some other doc, could there be at least a link to that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
