vogievetsky commented on a change in pull request #11416:
URL: https://github.com/apache/druid/pull/11416#discussion_r667233468
##########
File path: web-console/script/create-sql-docs.js
##########
@@ -53,17 +57,17 @@ const readDoc = async () => {
}
}
- // Make sure there are at least 10 functions for sanity
- if (functionDocs.length < 10) {
+ // Make sure there are enough functions found
+ if (functionDocs.length < EXPECTED_NUMBER_OF_FUNCTIONS) {
Review comment:
the constant should be renamed. I don't want someone adding a few SQL
function to have to update this. If the SQL docs format change then this will
still catch it because the number will drop from 130s to like 15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
