520lailai edited a comment on issue #9780:
URL: https://github.com/apache/druid/issues/9780#issuecomment-879454936
I pull the new code from your branch: spark_druid_connector, I have some
questions about it.
Class : DruidDataWriterFactory
Function: generateDimensions()
1 // No dimensions provided, assume all non-excluded non-metric columns are
dimensions.
2 if (dimensionsStr == DruidConfigurationKeys.dimensionsDefaultKey._2
|| dimensionsStr.isEmpty) {
3 val nonDimColumns = metrics ++ excludedDimensions :+ tsCol
4 val dimensions =
schema.fieldNames.filterNot(nonDimColumns.contains(_))
5 val excessDimensions =
dimensions.filterNot(schema.fieldNames.contains(_))
6 if (excessDimensions.nonEmpty) {
7 logWarn(s"Dimensions contains columns not in source df! Excess
columns: ${excessDimensions.mkString(", ")}")
}
the number 5 line : What is the point of doing this? the 'dimensions' are
all from 'schema.fieldNames' , so the number 5 will always return empty array.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
