jihoonson commented on pull request #10920:
URL: https://github.com/apache/druid/pull/10920#issuecomment-879620914
Hi @JulianJaffePinterest, apologize for not having a look earlier and thank
you for your patience! I know there are many people out there who want this, so
thank you again for making this PR. I haven't gone through all changes because
this is a giant PR. I bet none of committers would probably not able to do a
careful review for such a giant PR in the near future. Do you think you can
split this into smaller PRs? That will actually make the review process faster.
I also have 2 comments about this project.
- What is the current state of these APIs? Is it production-ready? Or is it
experimental? This should be documented.
- AFAIT, the thing you added is not a Druid extension, but spark APIs to
read from or write to Druid, isn't it? If so, I think it makes more sense to
place these codes in a new directory under the druid root such as
`${DRUID_ROOT}/spark-apis`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
