kfaraz commented on a change in pull request #11718:
URL: https://github.com/apache/druid/pull/11718#discussion_r722895453
##########
File path:
indexing-service/src/test/java/org/apache/druid/indexing/common/task/IndexTaskTest.java
##########
@@ -2604,6 +2613,81 @@ private static IndexIngestionSpec createIngestionSpec(
}
}
+ @Test
+ public void testAuthorizeRequest() throws Exception
+ {
+ // Need to run this only once
+ if (lockGranularity == LockGranularity.SEGMENT) {
Review comment:
This is a parameterized unit test. So every test method is run once for
SEGMENT granularity and once for TIME_CHUNK. Since this test method does not
depend on granularity, figured we should run it only once.
We could explain this part better in the comment or just remove the check.
Please let me know what you think would be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]