pjain1 commented on a change in pull request #11309:
URL: https://github.com/apache/druid/pull/11309#discussion_r736200323
##########
File path:
server/src/main/java/org/apache/druid/server/coordination/SegmentLoadDropHandler.java
##########
@@ -369,7 +392,7 @@ private void addSegments(Collection<DataSegment> segments,
final DataSegmentChan
numSegments,
segment.getId()
);
- loadSegment(segment, callback, config.isLazyLoadOnStart());
+ loadSegment(segment, callback, config.isLazyLoadOnStart(),
loadSegmentsIntoPageCacheOnBootstrapExec);
Review comment:
Since loading segment is synchronous where as loading into page cache is
async then it might happen that historical has announced itself but
`loadSegmentsIntoPageCacheOnBootstrapExec` is still copying segments to null
stream which can take time depending on IO throughput of the disk. I thought
the point of the PR is to warm up the page cache before historical announces
itself ready and hence no warm up delays and performance issues after reboot.
Am I missing something here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
