[GitHub] [druid] jon-wei commented on a change in pull request #11961: Add parse error list API for stream supervisors, use structured object for parse exceptions, simplify parse exception message

[GitBox]

jon-wei commented on a change in pull request #11961:
URL: https://github.com/apache/druid/pull/11961#discussion_r764464756



##########
File path: 
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskClient.java
##########
@@ -224,6 +231,31 @@ public DateTime getStartTime(final String id)
     }
   }
 
+  public List<ParseExceptionReport> getParseErrors(final String id)
+  {
+    log.debug("getParseErrors task[%s]", id);
+
+    try {
+      final StringFullResponseHolder response = submitRequestWithEmptyContent(
+          id,
+          HttpMethod.GET,
+          "unparseableEvents",
+          null,
+          true
+      );
+      return response.getContent() == null || response.getContent().isEmpty()
+             ? Collections.emptyList()
+             : deserialize(response.getContent(), 
TYPE_REFERENCE_LIST_PARSE_EXCEPTION_REPORT);
+    }
+    catch (NoTaskLocationException e) {
+      return Collections.emptyList();

Review comment:
       I adjusted this and the above moving average method to log warnings

##########
File path: 
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java
##########
@@ -1132,6 +1168,26 @@ public Boolean isHealthy()
     }
   }
 
+  @Override
+  public List<ParseExceptionReport> getParseErrors()
+  {
+    try {
+      if 
(spec.getSpec().getTuningConfig().convertToTaskTuningConfig().getMaxParseExceptions()
 <= 0) {
+        return ImmutableList.of();
+      }
+      lastKnownParseErrors = getCurrentParseErrors();
+      return lastKnownParseErrors;
+    }
+    catch (InterruptedException ie) {
+      Thread.currentThread().interrupt();
+      log.error(ie, "getErrors() interrupted.");

Review comment:
       Updated log msg




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org