clintropolis commented on a change in pull request #11923: URL: https://github.com/apache/druid/pull/11923#discussion_r766514916
########## File path: sql/src/main/java/org/apache/druid/sql/calcite/rule/DruidLogicalValuesRule.java ########## @@ -93,24 +94,28 @@ public void onMatch(RelOptRuleCall call) * * @throws IllegalArgumentException for unsupported types */ + @Nullable @VisibleForTesting static Object getValueFromLiteral(RexLiteral literal, PlannerContext plannerContext) { + if (RexLiteral.value(literal) == null) { Review comment: er, `CAST(null as boolean)` should be null i think... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org