capistrant commented on issue #12526: URL: https://github.com/apache/druid/issues/12526#issuecomment-1135937999
> I wish I could upvote this, I think it's a great idea. Admins or DBAs like to keep things around a while, in case anyone screams, then clean up later. Not based on segment start or end dates, but based on when the "delete" button was hit (so to speak). > > One comment, you mention "Exempting overshadowed segments from the last decision point mentioned above." Shouldn't "overshadowed" be "unused"? (Eg, including segments manually marked as unused.) I intentionally used the word "overshadowed". Whether or not I am correct is another story. My thinking here is that an overshadowed segment is a special subset of unused segments. It is a subset that, as far as I can tell, does not fit the logic of being retained if interval_end is equal to or greater than `now - druid.coordinator.killDurationToRetain`. The utility of keeping an unused segment around with this config is to be able to get it back to used. However, since it is overshadowed, another, newer version of the segment would flip to be used if its interval went to used. Maybe I'm way off base here? Also, this point is a bit of a side quest of the proposal. The main thing I'm shooting for is the buffer period. So if I am not accurate on the overshadowed bit it could be amended or thrown out -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
